Patches to MWorks 20110510, v0.4.5

Support
1

Hi Chris,

Here are some diffs for changes I made to the nightly of May 10, to mw_client, and mw_client_plugins (mostly the variables window).

If the underlying code has changed much since May 10, I can integrate my changes with a more recent nightly, if you wish.

Thanks,

Jon

2

Attachments:

3

Hi Jon,

Thanks for the patches. I agree that saving and restoring the open client windows and the expanded/collapsed state of the variables window makes sense and definitely improves the client’s usability.

However, I’m hesitant to commit these changes (just as I have been with your previous client patches), because my past experiences mucking around in this area have convinced me that the whole client-plugin infrastructure is quite brittle, and even small, seemingly simple changes can break things in unexpected ways. (As an example, I offer the two lines of code that I added in an attempt to fix this bug, which somehow completely broke the eye calibrator window.)

My point is that implementing these changes correctly is going to be more work than just applying your patches and committing. While it’s definitely on the to-do list (and has been since your first patch set), it may be a while before I get to it.

Thanks,
Chris